fix: FlareSkill PB update #1162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkrising
approved these changes
Aug 27, 2024
| ...Object.entries(gptConfig.providedMetrics), | ||
| ...Object.entries(gptConfig.derivedMetrics), | ||
| ]) { | ||
| for (const [key, conf] of [...Object.entries(gptConfig.optionalMetrics)]) { |
There was a problem hiding this comment.
jesus this is a pretty rough bug. will need to merge this and then maybe run some rederivations on the database....
|
That bug is going to cause some serious trouble and I can't merge this without taking down the site for a minute, as this will change score checksumming, resulting in duplicate scores everywhere. Blegh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new PB merge function to update flare in PB scores. This will also fix the profile ranking.
Some actions need to be done to update existing data :
enumIndexesforscoreData.optionalin scores, since there was a bug inderivers.tsthat prevented the creation of thoseoptional.enumIndexes